[ci] script to validate tutorials were built in > 0 sec #2031
Conversation
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
clee2000
changed the title
clee2000
changed the title
| + "python code in this tutorial probably didn't run:\n{}".format( | ||
| "\n".join(did_not_run) | ||
| ) |
There was a problem hiding this comment.
Nit
| + "python code in this tutorial probably didn't run:\n{}".format( | |
| "\n".join(did_not_run) | |
| ) | |
| + f"python code in this tutorial probably didn't run:\n{'\n'.join(did_not_run)}" | |
| ) |
There was a problem hiding this comment.
the black formatter was angry about the backslash inside the brackets for the f-string f-string expression part cannot include a backslash
| ] | ||
|
|
||
| # when the tutorial is fixed, remove it from this list | ||
| KNOWN_BAD = [ |
There was a problem hiding this comment.
Can we call it something other than bad?
Some tutorials are intentionally disabled. TTS tutorial is disabled because conflicting dependency issue but the original tutorial is executed on TorchAudio CI and we make sure it works.
There was a problem hiding this comment.
which tutorial is this? i can put it in the ok_to_not_run list, which isnt really a better name
the end goal is that we fix everything in the known bad list or decide that its ok to to run (b/c it has no code or some other reason)
If the running time is 0 minutes 0.000 seconds this means that python code probably didn't run either due to error or to lacking python code, so we check that the output doesn't have this string.
I don't want to break everyone's builds so we have a list of known bad tutorials that currently fail and only fail if there is a new one that is not on this list.
Example of failure: https://app.circleci.com/pipelines/github/pytorch/tutorials/6423/workflows/9f59712e-0d3b-428c-81cc-13d5eb22f259/jobs/125997